Code quality: Fix typos #67304

szepeviktor · 2024-11-26T09:04:31Z

What?

Found few years of typos.

How?

Would you like me to work on it?

github-actions · 2024-11-26T09:04:49Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: szepeviktor <[email protected]>
Co-authored-by: gziolo <[email protected]>
Co-authored-by: t-hamano <[email protected]>
Co-authored-by: michalczaplinski <[email protected]>
Co-authored-by: spacedmonkey <[email protected]>
Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: getdave <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions · 2024-11-26T09:05:08Z

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @szepeviktor! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

packages/block-editor/src/components/index.js

t-hamano

@szepeviktor Thanks for the cleanup.

I think this PR contains a lot of unnecessary changes that need to be fixed and go through all CI. Could you address these issues?

docs/manifest.json

packages/block-editor/src/components/global-styles/filters-panel.js

packages/components/src/combobox-control/test/index.tsx

packages/components/src/surface/test/__snapshots__/index.tsx.snap

packages/components/src/utils/strings.ts

packages/react-native-editor/__device-tests__/helpers/utils.js

packages/react-native-editor/bin/test-e2e-setup.sh

patches/react-autosize-textarea+7.1.0.patch

...ste-should-cut-partial-selection-and-merge-like-a-normal-delete---not-forward-2-chromium.txt

...d-paste-plain-text-in-plain-text-context-when-cross-block-selection-is-copied-2-chromium.txt

gziolo · 2024-12-23T08:56:34Z

@t-hamano, I addressed your feedback related to the slug change for the developer documentation page. I also rebased the PR with the latest changes from trunk. There are so many quality improvements that it would be worth bringing it to the finish line.

Could you resolve the lint errors first to ensure it passes all CI? If you run npm run lint:js:fix, all lint errors will be resolved.

Yes, all of the issues are reported because of differences with how Prettier formats code. By the way, it would be cool to have GitHub integration that can be triggered with the label to automatically fix such issues.

@szepeviktor, that a cool usage of the tool. Very impressive given the complexity of the Gutenberg codebase. Thank you for working on this PR.

docs/reference-guides/interactivity-api/core-concepts/using-typescript.md

packages/block-editor/src/components/text-transform-control/README.md

t-hamano · 2024-12-23T13:49:21Z

lib/class-wp-theme-json-gutenberg.php

@@ -3417,7 +3417,7 @@ protected static function should_override_preset( $theme_json, $path, $override

 	/**
 	 * Returns the default slugs for all the presets in an associative array
-	 * whose keys are the preset paths and the leafs is the list of slugs.
+	 * whose keys are the preset paths and the leaves is the list of slugs.


Note: This typo is already fixed in the core, so a backport changelog should not be necessary.

https://github.com/WordPress/wordpress-develop/blob/07be2445e45066147105206da08acf31bcee974d/src/wp-includes/class-wp-theme-json.php#L3386

…pescript.md

…ADME.md

t-hamano · 2024-12-23T13:53:47Z

@gziolo Thanks for the fix.

I've checked all the files again and we should be able to ship this PR.

Could you resolve the lint errors first to ensure it passes all CI? If you run npm run lint:js:fix, all lint errors will be resolved.

Yes, all of the issues are reported because of differences with how Prettier formats code. By the way, it would be cool to have GitHub integration that can be triggered with the label to automatically fix such issues.

What would it take to get the Static Analysis CI to pass? I checked out this branch and opened the file that is causing the lint error, but my code editor doesn't give any warnings 🤔

gziolo · 2025-01-03T11:26:37Z

@michalczaplinski, your review status is blocking this PR. Is there anything you want to be updated outside the Prettier formatting issues discussed above?

I checked out this branch and opened the file that is causing the lint error, but my code editor doesn't give any warnings.

Exwcuting npm run format on the branch should do the trick. @szepeviktor, could you run it in your branch, commit changes, and push it to GitHub? It should unblock this PR.

szepeviktor · 2025-01-03T11:33:20Z

@gziolo That is hard.
I need a computer ...

szepeviktor · 2025-01-03T12:12:13Z

Done 🍏

gziolo · 2025-01-03T14:02:52Z

Thank you. For me, the changes look good; I will leave the final call to @t-hamano and @michalczaplinski, who shared some concerns previously.

t-hamano

I think it's OK to merge this PR. This PR is indeed huge, but I think all the feedback has been addressed correctly.

packages/block-library/src/query/edit/inspector-controls/author-control.js

…r-control.js

michalczaplinski · 2025-01-06T17:06:37Z

packages/block-library/src/gallery/use-get-new-images.js

@@ -56,7 +56,7 @@ export default function useGetNewImages( images, imageData ) {
 						currentImage.clientId === image.clientId
 				) &&
 				imageData?.find( ( img ) => img.id === image.id ) &&
-				! image.fromSavedConent
+				! image.fromSavedContent


Nice, this is an actual bugfix - image.fromSavedConent does not exist.

michalczaplinski

I've looked through all the files and they should be good to go 👍 .

Interesting which words are most commonly misspelt. I think overridden takes the crown, which I've also always spelled as with one d 😅 .

michalczaplinski · 2025-01-06T17:53:32Z

Looks like an e2e test was faliing. I've merged trunk into this branch which hopefully solves it. Let's wait for the CI.

michalczaplinski · 2025-01-06T18:36:07Z

Tests passed. Thanks for the PR @szepeviktor !

szepeviktor · 2025-01-06T18:46:16Z

Glad to contribute.

…ry/interactivity-lazy-hydration * 'trunk' of https://github.com/WordPress/gutenberg: (143 commits) Update: Bundle upload media. (#68522) Add: Media field changing ui to Dataviews and content preview field to posts and pages (#67278) Bump the react-native group with 2 updates (#68095) Check Storybook build on CI for PRs (#68466) Bump the github-actions group across 1 directory with 2 updates (#68436) Classic theme preview: remove admin-bar class name (#68519) Remove geriux as code owner (#68523) Post Featured Image: Adds control to clear the the overlay color (#68525) Components: Standardize reduced motion handling using media queries (#68421) Upgrade Playwright to v1.49 (#68504) Document Outline: Use block client ID as unique 'key' (#68502) Storybook: Add UnitControl story (#67346) Details: Add allowedBlocks and TemplateLock attributes (#68489) Post Comment Link: Show Border Control By Default (#68506) Query Total: Show Border Controls By Default (#68507) RSS: Added Colour support (#66419) Refactor: Separate input form styles to a dedicated stylesheet (#68501) Code quality: Fix typos (#67304) Page List: Added color support (#66430) Fix flaky DataViews list arraow nav e2e tests (#68503) ...

Fix typos

80c4cfc

github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Nov 26, 2024

spacedmonkey approved these changes Nov 26, 2024

View reviewed changes

Revert

e5e1faa

Mamaduka reviewed Nov 26, 2024

View reviewed changes

packages/block-editor/src/components/index.js Outdated Show resolved Hide resolved

t-hamano requested changes Nov 26, 2024

View reviewed changes

Merge branch 'trunk' into typos

91fa908

gziolo added the No Core Sync Required Indicates that any changes do not need to be synced to WordPress Core label Dec 23, 2024

gziolo changed the title ~~Fix typos~~ Code quality: Fix typos Dec 23, 2024

t-hamano reviewed Dec 23, 2024

View reviewed changes

t-hamano added 2 commits December 23, 2024 22:50

Update docs/reference-guides/interactivity-api/core-concepts/using-ty…

193ec0d

…pescript.md

Update packages/block-editor/src/components/text-transform-control/RE…

016f36f

…ADME.md

gziolo requested a review from michalczaplinski January 3, 2025 11:26

Fix CS

13e9133

t-hamano self-requested a review January 4, 2025 02:13

t-hamano reviewed Jan 4, 2025

View reviewed changes

packages/block-library/src/query/edit/inspector-controls/author-control.js Outdated Show resolved Hide resolved

Update packages/block-library/src/query/edit/inspector-controls/autho…

072eaa5

…r-control.js

t-hamano self-requested a review January 4, 2025 02:48

t-hamano approved these changes Jan 4, 2025

View reviewed changes

michalczaplinski reviewed Jan 6, 2025

View reviewed changes

michalczaplinski approved these changes Jan 6, 2025

View reviewed changes

Merge branch 'trunk' into typos

6b95e10

michalczaplinski merged commit 8ac0e79 into WordPress:trunk Jan 6, 2025
62 of 63 checks passed

github-actions bot added this to the Gutenberg 20.1 milestone Jan 6, 2025

szepeviktor deleted the typos branch January 6, 2025 18:46

michalczaplinski mentioned this pull request Jan 7, 2025

Fix typos, round two #68482

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Code quality: Fix typos #67304

Code quality: Fix typos #67304

szepeviktor commented Nov 26, 2024 •

edited

Loading

github-actions bot commented Nov 26, 2024 •

edited

Loading

github-actions bot commented Nov 26, 2024

t-hamano left a comment

gziolo commented Dec 23, 2024 •

edited

Loading

t-hamano Dec 23, 2024

t-hamano commented Dec 23, 2024

gziolo commented Jan 3, 2025

szepeviktor commented Jan 3, 2025

szepeviktor commented Jan 3, 2025

gziolo commented Jan 3, 2025

t-hamano left a comment

michalczaplinski Jan 6, 2025

michalczaplinski left a comment

michalczaplinski commented Jan 6, 2025 •

edited

Loading

michalczaplinski commented Jan 6, 2025

szepeviktor commented Jan 6, 2025

Code quality: Fix typos #67304

Code quality: Fix typos #67304

Conversation

szepeviktor commented Nov 26, 2024 • edited Loading

What?

How?

github-actions bot commented Nov 26, 2024 • edited Loading

github-actions bot commented Nov 26, 2024

t-hamano left a comment

Choose a reason for hiding this comment

gziolo commented Dec 23, 2024 • edited Loading

t-hamano Dec 23, 2024

Choose a reason for hiding this comment

t-hamano commented Dec 23, 2024

gziolo commented Jan 3, 2025

szepeviktor commented Jan 3, 2025

szepeviktor commented Jan 3, 2025

gziolo commented Jan 3, 2025

t-hamano left a comment

Choose a reason for hiding this comment

michalczaplinski Jan 6, 2025

Choose a reason for hiding this comment

michalczaplinski left a comment

Choose a reason for hiding this comment

michalczaplinski commented Jan 6, 2025 • edited Loading

michalczaplinski commented Jan 6, 2025

szepeviktor commented Jan 6, 2025

szepeviktor commented Nov 26, 2024 •

edited

Loading

github-actions bot commented Nov 26, 2024 •

edited

Loading

gziolo commented Dec 23, 2024 •

edited

Loading

michalczaplinski commented Jan 6, 2025 •

edited

Loading